Make Graceful Shutdown Run On Its Own Thread #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advanced the version to 1.8.0 as Java 7 support is being removed.
Removed the configuration for Java 7, and switched to trusty for access to openjdk8.
pfifer
added a commit
to pfifer/amazon-kinesis-client
that referenced
this pull request
Jul 25, 2017
* Execute graceful shutdown on its own thread * PR awslabs#191 * Issue awslabs#167 * Added support for controlling the size of the lease renewer thread pool * PR awslabs#177 * Issue awslabs#171 * Require Java 8 and later Java 8 is now required for versions 1.8.0 of the amazon-kinesis-client and later. * PR awslabs#176
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graceful shutdown currently requires that the caller make a call to
Future#getto trigger the shutdown process. This changes that to make the shutdown process run independently on a separate thread.To recreate a similar behavior the method
Worker#createGracefulShutdownCallablecan be used to create the underlying callable that triggers shutdown. Executing that callable on the main thread will trigger shutdown in a synchronous manner.Fixed #167