-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying a custom LeaseManager in Worker.Builder with tests #297
Conversation
Thanks for providing this. I'm looking at the changes, but don't have an ETA right now. |
Ok! Let me know if you need something else. If you have another solution to solve this problem that makes more sense for the project, let me know. |
I just need everyone to please confirm that we can use, modify, copy, and redistribute this contribution. Thanks |
Sure! How can I do that? |
No CLA is required, just need you to agree for us to distribute this. Did you based the changes off of @johnsonwj changes? If that's the case I need them to also agree to allow us to distribute the changes. |
From my side there is no problem at all. |
Apologies for not seeing this earlier! You have my permission to use/modify/copy/redistribute my contribution! |
You also have my permission to use/modify/copy/redistribute my contribution. |
Thanks, @pfifer ! |
Continuing the work started on PR:
#255
(sorry for creating a new PR)
Added tests as requested.