Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a custom LeaseManager in Worker.Builder with tests #297

Merged
merged 2 commits into from
Feb 14, 2018
Merged

Allow specifying a custom LeaseManager in Worker.Builder with tests #297

merged 2 commits into from
Feb 14, 2018

Conversation

felipegasparini
Copy link
Contributor

Continuing the work started on PR:
#255

(sorry for creating a new PR)

Added tests as requested.

@pfifer
Copy link
Contributor

pfifer commented Feb 12, 2018

Thanks for providing this. I'm looking at the changes, but don't have an ETA right now.

@felipegasparini
Copy link
Contributor Author

Ok! Let me know if you need something else.
My use case is similar to the others one that requested this change: Be able to use another implementation of LeaseManager (baked by another datastore).

If you have another solution to solve this problem that makes more sense for the project, let me know.

@pfifer
Copy link
Contributor

pfifer commented Feb 13, 2018

I just need everyone to please confirm that we can use, modify, copy, and redistribute this contribution.

Thanks

@felipegasparini
Copy link
Contributor Author

Sure! How can I do that?
Do you have a contributors license agreement or something similar?

@pfifer
Copy link
Contributor

pfifer commented Feb 13, 2018

No CLA is required, just need you to agree for us to distribute this. Did you based the changes off of @johnsonwj changes? If that's the case I need them to also agree to allow us to distribute the changes.

@felipegasparini
Copy link
Contributor Author

From my side there is no problem at all.
And yes, I actually just continued @johnsonwj contribution. So let's wait for him.
Thanks!

@johnsonwj
Copy link

Apologies for not seeing this earlier! You have my permission to use/modify/copy/redistribute my contribution!

@felipegasparini
Copy link
Contributor Author

You also have my permission to use/modify/copy/redistribute my contribution.

@pfifer pfifer merged commit 6fc1487 into awslabs:master Feb 14, 2018
@felipegasparini
Copy link
Contributor Author

Thanks, @pfifer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants