Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create table resilience #41

Closed
wants to merge 2 commits into from

Conversation

avram
Copy link

@avram avram commented Sep 23, 2015

This breaks the dependency of worker start on the CreateTable API in DynamoDB, which prevented KCL workers from starting during the us-east-1 DynamoDB outage today.

@samcday
Copy link

samcday commented Mar 2, 2016

Can we get this reviewed and merged please? We manage our DynamoDB table separately to our KCL app, and we use very strict IAM roles for access to the table. It's kinda silly that we have to grant the KCL app permission to create a table we know already exists! :)

@Jackyjjc
Copy link

sorry for pulling you in @pfifer, I saw you were being active on the other PRs. I work on the same team as Sam and we really want this PR to get merged so that we don't have the infrastructure overhead of managing extra IAM roles.

@pfifer pfifer added this to the v1.6.5 milestone Jul 25, 2016
@pfifer pfifer self-assigned this Jul 25, 2016
@pfifer
Copy link
Contributor

pfifer commented Jul 25, 2016

A version of this is already merged: 8fc5dd5

This PR, and Fix #36 Avoid failure on start due to CreateTable are very similar.

I'm starting the process of release to Maven today, and hope to have v1.6.5 out soon.

@pfifer
Copy link
Contributor

pfifer commented Jul 25, 2016

The change is committed, and will be released to Maven soon.

@pfifer pfifer closed this Jul 25, 2016
ychunxue pushed a commit to ychunxue/amazon-kinesis-client that referenced this pull request Jun 17, 2020
…el of the shard hierarchy (awslabs#41)

* Update NonEmptyLeaseTableSynchronizer algorithm to create leases for no more than one level of the shard hierarchy

* Add and fix unit tests for LATEST, TRIM_HORIZON, AT_TIMESTAMP

* Update unit tests

* Fix edge case of reading from TRIM with partial lease for one child shard

* Revert child shards optimization for TRIM/TIMESTAMP case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants