Join metrics publishing thread when shutting factory down. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would prefer to see the use of join with a timeout, and log message. This would ensure that if the metrics thread got stuck, there would be an indication of why shutdown is being blocked. Otherwise this looks good, and should ensure consistency during shutdown. Finally I just need you to confirm that we can use, modify, copy, and redistribute this contribution. Thanks. |
|
I confirm that this pull request may be modified, copied and redistributed under the terms of the Amazon Software License. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need
CWMetricsFactory.publicationThreadto complete before we can shut itsAwsCloudWatchclient down cleanly.