Use sts to construct stream arn #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanmsac
reviewed
Dec 19, 2022
Comment on lines
+214
to
+215
| arn << "arn:" << sts_arn.GetPartition() << ":kinesis:" << region << ":" << result.GetAccount() | ||
| << ":stream/" << stream_name; |
There was a problem hiding this comment.
Is this stream arn format same for all regions? I thought we had some issues with arn format in some regions?
There was a problem hiding this comment.
That's a good call out, we once had a problem with pod1, but I think the format is good for all public commercial regions
There was a problem hiding this comment.
yep, we should still test to make sure this works in all partitions.
Comment on lines
+214
to
+215
| arn << "arn:" << sts_arn.GetPartition() << ":kinesis:" << region << ":" << result.GetAccount() | ||
| << ":stream/" << stream_name; |
There was a problem hiding this comment.
yep, we should still test to make sure this works in all partitions.
aws/kinesis/core/pipeline.h
Outdated
| return arn_str; | ||
| } | ||
|
|
||
| LOG(warning) << "Failed to get StreamARN using STS GetCallerIdentity with exception: " |
There was a problem hiding this comment.
we should throw if this fails.
that will avoid operating in dual-mode, and have all applications start using ARN from this version onwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing
amazon-kinesis-producer-sampleBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.