Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version #1794

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Update version #1794

merged 2 commits into from
Sep 5, 2023

Conversation

disa6302
Copy link
Contributor

Issue #, if available:

What was changed?
Testing a commit in PIC to fix millisecond precision log timestamp display

Why was it changed?
The millisecond timestamp portion had 6 digits adding a timestamp which is confusing. This fixes the timestamp portion to be 3 digits only to be accurate

How was it changed?
Change made in PIC to assign only 3 digits space in buffer.

What testing was done for the changes?
Checking if the log lines in the CI include this fix

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.08% ⚠️

Comparison is base (6746884) 74.67% compared to head (14df187) 74.59%.
Report is 1 commits behind head on master.

❗ Current head 14df187 differs from pull request most recent head 6ddb4d9. Consider uploading reports for the commit 6ddb4d9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
- Coverage   74.67%   74.59%   -0.08%     
==========================================
  Files          46       46              
  Lines       11619    11612       -7     
==========================================
- Hits         8676     8662      -14     
- Misses       2943     2950       +7     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disa6302 disa6302 merged commit 15e6019 into master Sep 5, 2023
@disa6302 disa6302 deleted the release-1.8.1 branch September 5, 2023 18:31
@disa6302 disa6302 restored the release-1.8.1 branch September 19, 2023 22:48
disa6302 added a commit that referenced this pull request Dec 5, 2023
* Update version

* Update commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants