Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous get ice config #1854

Merged
merged 27 commits into from
Dec 13, 2023
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a4ec12a
Asynchronous get ice config
jdelapla Nov 27, 2023
c94f366
Fixing mac compile error, addressing comments, correcting spelling error
jdelapla Dec 9, 2023
a1a51be
clang format
jdelapla Dec 9, 2023
9fdf14c
fixing test util functions to include new APIs
jdelapla Dec 10, 2023
aad230d
Unused variables for certain compile time flags breaking mac compile
jdelapla Dec 10, 2023
129b549
Merge branch 'develop' into async-get-ice-config
jdelapla Dec 10, 2023
b9a4438
fixing more compile errors for mac
jdelapla Dec 10, 2023
2ca2c28
Fix a dead lock, and fix a test with the API changes
jdelapla Dec 11, 2023
6cd49bb
iceAgentRestart does not remove the IceServers since the old design r…
jdelapla Dec 11, 2023
a32a892
Update PIC build in an attempt to fix static build on Mac
jdelapla Dec 11, 2023
8ed07ce
Moving git tag back to develop, since develop has been updated
jdelapla Dec 11, 2023
210267c
remove geticeconfig from standard connect state machine flow
jdelapla Nov 26, 2023
a2bffb1
Async test, and moving geticeserverconfig out of the standard signali…
jdelapla Dec 11, 2023
7abe36b
clang format
jdelapla Dec 11, 2023
59001a9
Incorrect state transition
jdelapla Dec 12, 2023
59085eb
fixing async test
jdelapla Dec 12, 2023
592ed6c
Up the sleep time
jdelapla Dec 12, 2023
7688f7f
change async func for test to handle answer and offer
jdelapla Dec 12, 2023
7fb4483
change location of creating pointer pointer
jdelapla Dec 12, 2023
216465b
Fixing tests
jdelapla Dec 12, 2023
7b332bb
Fix gathering to allow reporting relay candidates even after all srfl…
jdelapla Dec 12, 2023
f598f6b
unit test, longer sleep on teardown of threadpool
jdelapla Dec 12, 2023
47477d6
Fixing tests
jdelapla Dec 12, 2023
c2d8a8a
Update samples based off feedback, fix clang compile error in test
jdelapla Dec 12, 2023
4d431cc
Moved iceUriCount increment, added comments to public API
jdelapla Dec 13, 2023
e9da5b5
fix mac compile error from unused variable for specific ifdef
jdelapla Dec 13, 2023
81122b9
Merge branch 'develop' into async-get-ice-config
jdelapla Dec 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Up the sleep time
  • Loading branch information
jdelapla committed Dec 12, 2023
commit 592ed6c77cb6d1c81fd7afc0c6c6fb180686903b
3 changes: 2 additions & 1 deletion tst/WebRTCClientTestFixture.cpp
Original file line number Diff line number Diff line change
@@ -306,10 +306,11 @@ bool WebRtcClientTestBase::connectTwoPeersAsyncIce(PRtcPeerConnection offerPc, P
EXPECT_EQ(STATUS_SUCCESS, setRemoteDescription(offerPc, &sdp));

asyncGetIceConfig(answerPc);

//lazy sleep added to this test that's needed because both peer connections are on the
//same device and we're not sending the remote candidates over the signaling client like
//we normally would. This results in a weird race condition
THREAD_SLEEP(HUNDREDS_OF_NANOS_IN_A_SECOND);
THREAD_SLEEP(3*HUNDREDS_OF_NANOS_IN_A_SECOND);
asyncGetIceConfig(offerPc);

if (pAnswerCertFingerprint != NULL) {
Loading