Fix signaling cache and GStreamer sample build on Windows #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassanctech
reviewed
Feb 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1935 +/- ##
===========================================
- Coverage 76.13% 76.11% -0.02%
===========================================
Files 48 48
Lines 13709 13708 -1
===========================================
- Hits 10437 10434 -3
- Misses 3272 3274 +2 ☔ View full report in Codecov by Sentry. |
niyatim23
changed the title
hassanctech
reviewed
Feb 26, 2024
disa6302
approved these changes
Feb 27, 2024
niyatim23
added a commit
that referenced
this pull request
Feb 28, 2024
* fix readFile signaling cache windows * fix branch name * enable signaling api functionality tests on windows ci * try install zlib * zlib condition cmake * fix file cachine tests on Windows +Gstreamer sample build * filter failing signaling tests on Windows * dummy commit * strnlen * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
Modified the Windows CI and deserialization logic in Signaling caching
Why was it changed?
Signaling cache was broken on Windows. This change would fix it and some tests that were disabled on Windows
How was it changed?
By modifying the readFile in the PIC layer and fixing the deserialize function on Windows by introducing an additional check
What testing was done for the changes?
The tests pass in the CI. Ran the sample application to make sure the cache is being used instead of the describe call
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.