Filter out non-operational and loopback interfaces #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1937 +/- ##
========================================
Coverage 76.11% 76.11%
========================================
Files 48 48
Lines 13711 13710 -1
========================================
Hits 10436 10436
+ Misses 3275 3274 -1 ☔ View full report in Codecov by Sentry. |
jdelapla
approved these changes
Mar 4, 2024
sirknightj
reviewed
Mar 4, 2024
| // Skip inactive interfaces and loop back interfaces | ||
| if (aa->OperStatus == IfOperStatusUp && aa->IfType != IF_TYPE_SOFTWARE_LOOPBACK) { | ||
| char ifa_name[BUFSIZ]; | ||
| memset(ifa_name, 0, BUFSIZ); |
There was a problem hiding this comment.
Minor but we should be using the macros from pic (MEMSET, CHAR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.