[Bug] GStreamer sample #1972
Merged
[Bug] GStreamer sample #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disa6302
reviewed
Apr 18, 2024
stefankiesz
requested changes
Apr 19, 2024
disa6302
previously approved these changes
Apr 22, 2024
stefankiesz
approved these changes
Apr 22, 2024
sirknightj
reviewed
Apr 22, 2024
disa6302
approved these changes
Apr 22, 2024
niyatim23
added a commit
that referenced
this pull request
May 1, 2024
* gst-sample-fix * modify the message * fix windows * set to null * fix pts and eos in sample * unused var removed * move null init
Closed
disa6302
pushed a commit
that referenced
this pull request
May 2, 2024
* gst-sample-fix * modify the message * fix windows * set to null * fix pts and eos in sample * unused var removed * move null init
niyatim23
added a commit
that referenced
this pull request
May 2, 2024
* gst-sample-fix * modify the message * fix windows * set to null * fix pts and eos in sample * unused var removed * move null init
Merged
niyatim23
added a commit
that referenced
this pull request
May 9, 2024
* Add H265 and AAC frames (#1962) * aac and h265 frames * update readme * update cmake with h265 and aac * clang formay * [Sample] GStreamer media receiver (#1963) * create the gst receiver * fix ci * cmake flag * clang format, add cmake flag in ci * install gstreamer on ci * use macos12 * use defined values * indent * clang-format * readme and commentsa * clang :( * install glib to fix ci * -DCOMPILER_WARNINGS=FALSE to fix the CI * fix macos version for clang * address comments and cleanup * new viewer with gst * clang-format * missing null check * address comments * -DCOMPILER_WARNINGS=TRUE * clang-format * gst_init_check * fix CI * fix CI * [Bug] GStreamer sample (#1972) * gst-sample-fix * modify the message * fix windows * set to null * fix pts and eos in sample * unused var removed * move null init * Version check job (#1974) * Version check job * Working Version check template * Retest with dev * Version lint * Version lint * use new frames (#1978) * Sample TWCC implementation (#1957) * encoder bitrate change based on twcc * Change to 5% inc and dec * modify percentages * ema based calc * EMa fix * Nits * Readme * flip * memset remove * Readme update, move enable flags to createSampleConfiguration * Add codecov token * [Feature] Add H265 support with SDP, RTP payloader-deplayloader (#1965) * Add RtpH265Payloader.c and RtpH265Payloader.h * Add support for H265 in PeerConnection/SessionDescription * Add support for H265 in PeerConnection/PeerConnection * Add support for H265 in PeerConnection/Rtp * Add support for H265 in samples/Common.c * Add support for H265 in samples/kvsWebRTCClientMaster.c * rtp, sdp fix, flag removed, clang fixed, windows build fixed, new test added * test fix * cleanup * cleanup * remove #if 0 * clang * presentation ts fix * clang-format fix * PKG_CONFIG_PATH in kvscommon * missing bracket * fix all builds * ci * cleanup * fix windows build, rename h265 defs * remove duplicate line from h264 and h265 * sample changes * address comments * clang-format * gst sample * cleanup args * clang-format * cleanup * add sdp tests * address comments * address commentas * set default payload type only once * address comments * fix height and width * sdp change --------- Co-authored-by: Hongli Wang <hongliwo@amazon.com> * Version bump, fix tests, remove enableIceStats * Remove AAC related changes * Remove AAC frames * Clang format * fix kvsWebrtcClientMasterGstSample.c name in CMakeLists --------- Co-authored-by: Divya Sampath Kumar <disa6302@colorado.edu> Co-authored-by: Hongli Wang <hongliwo@amazon.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
Why was it changed?
It was removed because it segfaults with the JS viewer because the JS viewer modifies caps mid-streaming. It is not supported by matroskamux in GStreamer. It has been broken but didn't manifest itself earlier because autovideosink in the previous pipeline did not work at all
How was it changed?
Removing the receiver from the GStreamer sample application as it was non-functional
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.