Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MID_NTP macro definition #1999

Closed
wants to merge 1 commit into from
Closed

Conversation

aggarg
Copy link
Contributor

@aggarg aggarg commented May 29, 2024

Issue #, if available:

What was changed?
Updated the MID_NTP macro definition to use the parameter passed to it.

Why was it changed?
The macro definition was not using the parameter passed to it. It was working so far because the variable name used in the macro definition happened to be same as the one at the call site.

How was it changed?
Updated the macro definition.

What testing was done for the changes?
None.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The macro definition was not using the parameter passed to it. It was
working so far because the variable name used in the macro definition
happened to be same as the one at the call site.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@hassanctech hassanctech self-assigned this May 29, 2024
Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch!

@aggarg aggarg closed this May 29, 2024
@aggarg aggarg deleted the fix_macro branch May 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants