Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #2009

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Build fixes #2009

merged 2 commits into from
Jun 13, 2024

Conversation

disa6302
Copy link
Contributor

Issue #, if available:

What was changed?

  • Adding threadpool to ensure it is installed along with other webrtc libraries
  • Removing the unnecessary linkage to stun, rtp and sdp libraries in samples since we do not directly use its APIs

Why was it changed?

  • Threadpool was added to ensure custom path install works for threadpool and does not cause linkage failure.

How was it changed?

  • Check the cmake file changes made in the PR

What testing was done for the changes?

  • Allowing CI to run to ensure this does not break anything
  • Ran local build by setting OPEN_SRC_INSTALL_PREFIX and CMAKE_INSTALL_PREFIX paths.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (cae3c67) to head (aa53fd1).

Current head aa53fd1 differs from pull request most recent head 86c1ca3

Please upload reports for the commit 86c1ca3 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2009      +/-   ##
===========================================
- Coverage    88.65%   88.63%   -0.03%     
===========================================
  Files           48       48              
  Lines        12714    12714              
===========================================
- Hits         11272    11269       -3     
- Misses        1442     1445       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disa6302 disa6302 marked this pull request as ready for review June 11, 2024 16:28
hassanctech
hassanctech previously approved these changes Jun 11, 2024
Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@niyatim23 niyatim23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@disa6302 disa6302 merged commit 98188ff into develop Jun 13, 2024
30 checks passed
@disa6302 disa6302 deleted the build_fixes branch June 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants