-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time-to-first-frame metrics benchmarking and timeline chart #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirknightj
added
enhancement
New feature or request
Samples
Questions related to Samples
labels
Nov 14, 2023
sirknightj
reviewed
Nov 15, 2023
sirknightj
approved these changes
Nov 21, 2023
We'll merge this in at the same time as awslabs/amazon-kinesis-video-streams-webrtc-sdk-c#1846 |
disa6302
reviewed
Dec 14, 2023
disa6302
reviewed
Dec 14, 2023
disa6302
reviewed
Dec 18, 2023
disa6302
reviewed
Dec 20, 2023
disa6302
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
Introduced a new feature which allows receiving master-side metrics in the JS viewer
Why was it changed?
It would be easier to understand the time-to-first-frame and which process on both sides is time-consuming and how much time does each API call take
How was it changed?
What testing was done for the changes?
Tested the changes locally by running the master first and the viewer first to see that the plot had all the relevant values
Viewer is started first
Master is started first
Tooltip
Datachannel messages from master
Checkbox
Timer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.