-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.0.0: Run ASH as non-root user, add explicit CI stage #109
base: main
Are you sure you want to change the base?
Release v2.0.0: Run ASH as non-root user, add explicit CI stage #109
Conversation
…rtjh2/automated-security-helper into feature/78/run-container-non-root
…tly in offline mode so findings are still captured
…8/run-container-non-root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting one minor change.
Includes changes from #79 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I understand the addition of --target
to the command-line options, since it is similar to the docker build
command-line option of --target
. However, in the context of the ash
command-line, I think it might cause some confusion.
Also, in the command-line help, it says image to build
- it probably should say image to run/build
.
…t/offline-mode-expansion
…memory settings for Node, script help functions
…t/offline-mode-expansion
Add additional checks for build expiry and ignoring Checkov/NPM Audit during offline mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a couple smoke tests - this looks OK to me. Approving.
Issue #, if available:
N/A
Description of changes:
v2.0.0
Breaking Changes
ci
stage of theDockerfile
:via
ash
CLIvia
docker
or other OCI CLIdocker build --tag automated-security-helper:ci --target ci .
Features
Fixes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.