-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON output format as non-default output option via new --format parameter #82
Conversation
ASH Scan Output - amd64 - ubuntu-latest$ cat ash_stdout.txt
Resolved OCI_RUNNER to: /usr/bin/docker
Building image automated-security-helper:local -- this may take a few minutes during the first build...
Running ASH scan using built image... Show aggregated_results.txt |
…, sets ASH_OUTPUT_FORMAT env var inside container, defaults to text format
…lue is something other than "text"
… where needed, and version_check method to be more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do a deep review of asharp.py
. Cursory look - it looks OK.
Minor comments in other places.
…uth is now in pyproject.toml, set default ASH_OUTPUT_FORMAT value
Added Nathan to the authors data point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates look good to me - let's get this into main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok as written for now.
Issue #, if available: #50
Description of changes:
--format
parameter toash
/ash-multi
scripts to enable additional output integrations, beginning with ASHARP (Automated Security Helper Aggregated Report Parser) as the intermediary data model to enable subsequent conversion from there.automated_security_helper
Python code as a module of the same name from within newsrc
directory, including poetry.lock and pyproject.toml files to support. This module includes theasharp
script (CLI tool) that enabled programmatic parsing of the aggregated_results content in conjunction with the JSON output changes.automated_security_helper
module to Dockerfile--format
is a value other than the current default oftext
so scanners switch output to programmatically parseable output formats andasharp
is called to parse theaggregated_results.txt
file intoaggregated_results.txt.json
.pyproject.toml
for all projects, removed__version__
file to coincide with this.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.