Display warning when accessing API page with no credentials; #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leadiato
requested review from
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
ghost
suggested changes
Nov 27, 2020
|
@amazon-meaisiah I've reverted whitespace removal. |
ghost
approved these changes
Dec 1, 2020
|
@etsung-aws @skylarbemus @jiyou95 @MynockSpit any chance to review this PR? |
ghost
requested review from
aws-amit,
ichuckyi,
lloypark and
zil-aws
and removed request for
MynockSpit,
etsung-aws and
jiyou95
@amazon-meaisiah rebased completed ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing API page with no previous sign-in, an infinite spinning wheel is presented to the user with no explanation of what happened.
*Description of changes:
self.jsservice.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.