acquire() and release() functions return pointers, for better ergonomics #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ergonomics. This has gradually become the new standard in our codebase.
graebm
changed the title
TingDaoK
approved these changes
Nov 18, 2022
waahm7
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time, we've settled on this as the "standard" way of doing acquire/release functions in our codebase.
I've updated anywhere we were calling one of these functions, then updating a pointer, so that we do it in 1 line of code instead of 2.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.