Pause resume update #235
Merged
Pause resume update #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
approved these changes
Nov 18, 2022
graebm
reviewed
Nov 18, 2022
graebm
reviewed
Dec 1, 2022
graebm
approved these changes
Dec 1, 2022
include/aws/s3/s3_client.h
Outdated
| * @param resume_token outputs the json string with the state that can be used to resume the operation. | ||
| * @return | ||
| * @param resume_token resume token | ||
| * @return error code. |
There was a problem hiding this comment.
note somewhere, either in the @return or in the "Corner cases" that it will raise the AWS_ERROR_S3_PAUSE_FAILED_REQUEST_COMPLETED error if he operation has already completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix handling of pause after request completes.
Switched pause interface to return token object instead of serializing everything to a string.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.