Test Revamp #246
Merged
Test Revamp #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 85.20% 84.23% -0.98%
==========================================
Files 17 16 -1
Lines 4306 4014 -292
==========================================
- Hits 3669 3381 -288
+ Misses 637 633 -4
|
graebm
reviewed
Jan 11, 2023
Co-authored-by: Michael Graeb <graebm@amazon.com>
Co-authored-by: Michael Graeb <graebm@amazon.com>
grrtrr
added a commit
to grrtrr/aws-c-s3
that referenced
this pull request
May 10, 2023
This fixes the hardcoded URL for the initial HeadObject call used by the CopyObject method. Also re-enable the tests that were accordingly disabled in awslabs#246.
grrtrr
added a commit
to grrtrr/aws-c-s3
that referenced
this pull request
May 10, 2023
This fixes the hardcoded URL for the initial HeadObject call used by the CopyObject method. Also re-enable the tests that were accordingly disabled in awslabs#246.
DmitriyMusatkin
added a commit
that referenced
this pull request
Jun 1, 2023
…ts (#284) * [CopyObject]: fix hardcoded URL, re-enable tests This fixes the hardcoded URL for the initial HeadObject call used by the CopyObject method. Also re-enable the tests that were accordingly disabled in #246. Co-authored-by: Dmitriy Musatkin <63878209+DmitriyMusatkin@users.noreply.github.com> Co-authored-by: Dmitriy Musatkin <musatkd@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
upload/AWS_S3_META_REQUEST_TYPE_COPY_OBJECTdoesn't work correctly, make it fail hard.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.