Fix Host header not including port #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
reviewed
Jan 19, 2023
| * - Only endpoint is set - Host header is created from endpoint. Port and | ||
| * Scheme from endpoint is used. | ||
| * - Both Host and Endpoint is set - Host header must match Authority of | ||
| * Endpoint uri. Port and Scheme from endpoint is used. |
There was a problem hiding this comment.
scheme is used to determine whether its https or http. we can explicitly say that, but i though it was clear enough
TingDaoK
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
There is some overlap between meta request endpoint and Host header. Clarified the docs what happens depending on which one is used.
Fix logic comparing the two if both are set with ports.
Made Host header optional if endpoint is provided
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.