Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async streaming - WIP #299

Merged
merged 9 commits into from
Jun 1, 2023
Merged

Async streaming - WIP #299

merged 9 commits into from
Jun 1, 2023

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Jun 1, 2023

Work in Progress support for async streaming of the request body. We've tested that this doesn't break the existing synchronous streaming. But actual async streaming hasn't been tested yet, there are sure to be bugs. Committing to main now, before it's 100% complete, so it's simpler to continue working on this in parallel.

These changes have already been reviewed in the following incremental PRs:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #299 (3194636) into main (21b0a10) will increase coverage by 0.04%.
The diff coverage is 94.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   85.77%   85.82%   +0.04%     
==========================================
  Files          17       17              
  Lines        4717     4910     +193     
==========================================
+ Hits         4046     4214     +168     
- Misses        671      696      +25     
Impacted Files Coverage Δ
source/s3.c 96.15% <ø> (ø)
source/s3_client.c 87.91% <66.66%> (-0.32%) ⬇️
source/s3_copy_object.c 36.94% <80.00%> (+1.65%) ⬆️
source/s3_auto_ranged_put.c 93.09% <94.89%> (+0.41%) ⬆️
source/s3_request_messages.c 70.99% <95.45%> (+0.13%) ⬆️
source/s3_default_meta_request.c 94.24% <97.43%> (+1.10%) ⬆️
source/s3_auto_ranged_get.c 98.18% <100.00%> (-0.35%) ⬇️
source/s3_meta_request.c 92.81% <100.00%> (-1.75%) ⬇️

@graebm graebm merged commit 931d258 into main Jun 1, 2023
@graebm graebm deleted the async-stream branch June 1, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants