-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async streaming - WIP #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # source/s3.c # source/s3_auto_ranged_put.c # source/s3_client.c # source/s3_default_meta_request.c
Co-authored-by: Michael Graeb <graebm@amazon.com>
The 1st pass async streaming PR #290 was merged before I could address all the feedback.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 85.77% 85.82% +0.04%
==========================================
Files 17 17
Lines 4717 4910 +193
==========================================
+ Hits 4046 4214 +168
- Misses 671 696 +25
|
waahm7
approved these changes
Jun 1, 2023
DmitriyMusatkin
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress support for async streaming of the request body. We've tested that this doesn't break the existing synchronous streaming. But actual async streaming hasn't been tested yet, there are sure to be bugs. Committing to
main
now, before it's 100% complete, so it's simpler to continue working on this in parallel.These changes have already been reviewed in the following incremental PRs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.