Speed up async streaming. #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug that prevented any parallelism in async-streams. - Reduce gap between sequential reads by running client->update() as soon as the read completes, rather than waiting until after signing is complete. - Rename ~num_parts_sent~ -> `num_parts_started`, for clarity
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
- Coverage 88.99% 88.99% -0.01%
==========================================
Files 17 17
Lines 4936 4933 -3
==========================================
- Hits 4393 4390 -3
Misses 543 543
|
…resuming a canceled upload. Bug was: When resuming a paused upload, we increment num_parts_started/completed to account for parts we don't need to re-upload. But we forgot to update `num_parts_read`. Updating the docs on `num_parts_read` to reflect this new meaning was ... pretty confusing "number of parts started, and read from stream, or that we don't need to read from stream, btw doesn't necessarily reflect the index of where we are due to skipping etc arglbargl" Decided to just rename the variable to be what we actually care about: ~num_parts_read~ -> `num_parts_pending_read`. Now it goes up and down (not just up) and means what it says and is hopefully less bug-prone.
… the actual error-code. Stop covering it with AWS_ERROR_S3_RESUME_FAILED.
DmitriyMusatkin
approved these changes
Jun 12, 2023
jamesbornholt
added a commit
to jamesbornholt/mountpoint-s3
that referenced
this pull request
Jun 14, 2023
Picks up awslabs/aws-c-s3#313, which fixes concurrency in async streaming
jamesbornholt
added a commit
to jamesbornholt/mountpoint-s3
that referenced
this pull request
Jun 14, 2023
Picks up awslabs/aws-c-s3#313, which fixes concurrency in async streaming Signed-off-by: James Bornholt <bornholt@amazon.com>
jamesbornholt
added a commit
to awslabs/mountpoint-s3
that referenced
this pull request
Jun 14, 2023
Picks up awslabs/aws-c-s3#313, which fixes concurrency in async streaming Signed-off-by: James Bornholt <bornholt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_parts_sent->num_parts_started, for claritynum_parts_read->num_parts_pending_read.num_parts_readalong withnum_parts_startedandnum_parts_completedwhich threw off the math and lead to the upload stalling. It seemed simpler and more obvious to just track the number we care about, rather than have so many different numbers ticking up, from many different locations, and their meaning is weird when skipping is involved.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.