Move endpoint resolver private header to .c file #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMusatkin
approved these changes
Jun 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 88.88% 88.78% -0.11%
==========================================
Files 17 17
Lines 4947 4938 -9
==========================================
- Hits 4397 4384 -13
- Misses 550 554 +4 |
jamesbornholt
added a commit
to jamesbornholt/mountpoint-s3
that referenced
this pull request
Jun 23, 2023
This picks up awslabs/aws-c-s3#320 to unblock binding the endpoint resolver, and awslabs/aws-c-auth#203 to fix a bug in the IMDS client. Signed-off-by: James Bornholt <bornholt@amazon.com>
jamesbornholt
added a commit
to awslabs/mountpoint-s3
that referenced
this pull request
Jun 23, 2023
This picks up awslabs/aws-c-s3#320 to unblock binding the endpoint resolver, and awslabs/aws-c-auth#203 to fix a bug in the IMDS client. Signed-off-by: James Bornholt <bornholt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.