Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options more const #445

Merged
merged 8 commits into from
Jul 13, 2024
Merged

Make options more const #445

merged 8 commits into from
Jul 13, 2024

Conversation

DmitriyMusatkin
Copy link
Contributor

Issue #, if available:

Description of changes:
make everything passed in by pointer in options const as we always copy the underlying data.
everything that is ref counted is kept as is, since refcounted functions dont play with const ptrs nicely

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (813c418) to head (86c4d9a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files          20       20           
  Lines        6092     6092           
=======================================
  Hits         5460     5460           
  Misses        632      632           

Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advise checking this branch from aws-crt-cpp, and making sure it all works nicely, before merging

@DmitriyMusatkin
Copy link
Contributor Author

I'd advise checking this branch from aws-crt-cpp, and making sure it all works nicely, before merging

crt cpp actually does not wrap s3 now. i checked cpp sdk and its fine with it. i will check other bindinds

@DmitriyMusatkin DmitriyMusatkin merged commit 0ab4d58 into main Jul 13, 2024
30 checks passed
@DmitriyMusatkin DmitriyMusatkin deleted the const_options branch July 13, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants