Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cdk): make bootstrapping not require --app #1191

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 16, 2018

Improve the error message when needing to bootstrap while using assets.
Also make it not necessary to have '--app' in there when bootstrapping
if an environment name is given.

This makes the toolkit easier to use in integration tests, where the
cdk.json is generated and it's not clear what the argument to --app
should be (nor should it be necessary if the environment identifier has
enough information in it to reconstruct the Environment object).

This also refactors the code somewhat so related code (for running the
CX App and parsing its output) is together.

Fixes #1188.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Improve the error message when needing to bootstrap while using assets.
Also make it not necessary to have '--app' in there when bootstrapping
if an environment name is given.

This makes the toolkit easier to use in integration tests, where the
cdk.json is generated and it's not clear what the argument to --app
should be (nor should it be necessary if the environment identifier has
enough information in it to reconstruct the Environment object).

This also refactors the code somewhat so related code (for running the
CX App and parsing its output) is together.

Fixes #1188.
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Nov 16, 2018

Did run the integ tests.

@rix0rrr rix0rrr merged commit c7b1004 into master Nov 16, 2018
@rix0rrr rix0rrr deleted the huijbers/bootstrap-message branch November 16, 2018 13:55
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bootstrap message print out exact command & environment
3 participants