add additional device pool to test #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazhvera
approved these changes
Jun 14, 2024
| @@ -12,6 +12,7 @@ | |||
| parser.add_argument('--run_attempt', required=True, help="A unique number for each attempt of a particular workflow run in a repository") | |||
| parser.add_argument('--project_arn', required=True, help="Arn for the Device Farm Project the apk will be tested on") | |||
| parser.add_argument('--device_pool_arn', required=True, help="Arn for device pool of the Device Farm Project the apk will be tested on") | |||
| parser.add_argument('--device_pool', required=True, help="Which device pool is being used for this test") | |||
There was a problem hiding this comment.
Nit-Pick: The device_pool argument seems only setup a different file name for the test files. Is it mandatory to have different file names for the test?
There was a problem hiding this comment.
It's more for our own convenience when looking at the test runs on device farm itself. Otherwise you'd have to dig into the run itself to determine which device pool was run. It may or may not be mandatory to have a different name but having identically named tests is not ideal in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional Android 8.0.0 device pool for testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.