Flaky test pass1

[bretambrose]

WIP

• Update shared subscription test to remove invalid assertions on a property that does not necessarily hold (all subscriptions receive messages)
• Update SelfPubSub test to not use counting variables that are pointless (they won't ever be wrong) as well as unsafe from race conditions (they are set and read from different threads with no explicit synchronizations, also the future that was waited upon strictly happens-before the setting of the counter which leads to consistency issues)
• Update the double client id connection failure test to be more forgiving to potential race conditions between the two clients fighting over the client id

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.