Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Making 'configPath' optional in interfaces #418

Merged
merged 2 commits into from
Aug 10, 2023
Merged

fix: Making 'configPath' optional in interfaces #418

merged 2 commits into from
Aug 10, 2023

Conversation

malachi-constant
Copy link
Contributor

Closes #416

Fix

Making configPath optional in interfaces:

  • GetTagsProps
  • GetEnvironmentProps

@malachi-constant malachi-constant self-assigned this Aug 10, 2023
@malachi-constant malachi-constant linked an issue Aug 10, 2023 that may be closed by this pull request
config: Configurator interfaces marked as required, but default value is said to be assigned #416
Closed
@malachi-constant malachi-constant added the bug Something isn't working label Aug 10, 2023
chore: self mutation
a589946 
Signed-off-by: github-actions <github-actions@github.com>
@malachi-constant malachi-constant merged commit 98f48f3 into main Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolsgandhi anmolsgandhi anmolsgandhi approved these changes

@LeonLuttenberger LeonLuttenberger Awaiting requested review from LeonLuttenberger

Assignees

@malachi-constant malachi-constant

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config: Configurator interfaces marked as required, but default value is said to be assigned
2 participants
@malachi-constant @anmolsgandhi