Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the initial DefaultMessageManager implementation #24

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

ashovlin
Copy link
Contributor

Issue #, if available: DOTNET-6664

Description of changes: Adds the message manager, which was the last missing component for the subscriber workflow!

Some loose ends since I'm rushing to get this out before vacation:

  • We're now able to write integration tests more easily, though none are included here. We might want to break into a separate task. I've done some manual testing of single message workflows.
  • There's a TODO in the code, I'm unsure if we want to plumb the CancellationToken for the entire poller down into a single message's handling (and therefore its delete or visibility extension calls).
  • The unit test that a 3 second message handling with a 1 second visibility window will call extend either 2 or 3 times. I used Between so it always passes for now, but might need to tighten it up.
  • I haven't done any unit or manual/integration testing for more then one message in the queue at a time, so the synchronization around ActiveMessageCount hasn't been exercised much.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

src/AWS.Messaging/Services/IMessageManager.cs Outdated Show resolved Hide resolved
src/AWS.Messaging/Services/DefaultMessageManager.cs Outdated Show resolved Hide resolved
src/AWS.Messaging/Services/DefaultMessageManager.cs Outdated Show resolved Hide resolved
src/AWS.Messaging/Services/DefaultMessageManager.cs Outdated Show resolved Hide resolved
@ashovlin ashovlin force-pushed the shovlia/message-manager branch 2 times, most recently from 4540fbf to 3609da2 Compare April 14, 2023 21:50
@ashovlin ashovlin requested review from philasmar and normj April 14, 2023 21:57
src/AWS.Messaging/SQS/SQSMessagePoller.cs Outdated Show resolved Hide resolved
src/AWS.Messaging/SQS/SQSMessagePoller.cs Outdated Show resolved Hide resolved
src/AWS.Messaging/Services/DefaultMessageManager.cs Outdated Show resolved Hide resolved
src/AWS.Messaging/Services/DefaultMessageManager.cs Outdated Show resolved Hide resolved
@ashovlin ashovlin force-pushed the shovlia/message-manager branch from 3609da2 to bbf3ce8 Compare April 18, 2023 19:40
@ashovlin ashovlin requested review from normj and philasmar April 18, 2023 19:43
Copy link
Contributor

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small method rename but otherwise I'm good.

src/AWS.Messaging/Services/IMessageManager.cs Outdated Show resolved Hide resolved
@ashovlin ashovlin force-pushed the shovlia/message-manager branch from bbf3ce8 to 47dd473 Compare April 19, 2023 14:00
@ashovlin ashovlin merged commit 26799f8 into dev Apr 19, 2023
@ashovlin ashovlin deleted the shovlia/message-manager branch April 19, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants