-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the initial DefaultMessageManager implementation #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
requested changes
Apr 8, 2023
philasmar
reviewed
Apr 10, 2023
ashovlin
force-pushed
the
shovlia/message-manager
branch
2 times, most recently
from
April 14, 2023 21:50
4540fbf
to
3609da2
Compare
philasmar
approved these changes
Apr 17, 2023
normj
requested changes
Apr 18, 2023
src/AWS.Messaging/Configuration/SQSMessagePollerConfiguration.cs
Outdated
Show resolved
Hide resolved
ashovlin
force-pushed
the
shovlia/message-manager
branch
from
April 18, 2023 19:40
3609da2
to
bbf3ce8
Compare
normj
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small method rename but otherwise I'm good.
ashovlin
force-pushed
the
shovlia/message-manager
branch
from
April 19, 2023 14:00
bbf3ce8
to
47dd473
Compare
philasmar
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: DOTNET-6664
Description of changes: Adds the message manager, which was the last missing component for the subscriber workflow!
Some loose ends since I'm rushing to get this out before vacation:
CancellationToken
for the entire poller down into a single message's handling (and therefore its delete or visibility extension calls).Between
so it always passes for now, but might need to tighten it up.ActiveMessageCount
hasn't been exercised much.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.