Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add additional unit tests and update project dependencies #80

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

96malhar
Copy link
Contributor

@96malhar 96malhar commented Dec 5, 2023

Description of changes:

  1. Update all NuGet package references to their latest versions
  2. Added unit tests that assert the following:
    • Exceptions are thrown while creating a MessageEnvelope if PublisherMapping or SubscriberMapping are missing.
    • An exception is thrown when configuring Lambda message processor with invalid options.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to get fancy you could try NuGet's central package management feature instead of having the versions in all of the different project files. https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management

@96malhar 96malhar force-pushed the kmalhar/add-sec-tests branch from 710586e to 97aee1f Compare December 5, 2023 22:09
@96malhar 96malhar requested a review from normj December 5, 2023 22:12
@96malhar 96malhar merged commit f2a95d7 into dev Dec 5, 2023
5 checks passed
@96malhar 96malhar deleted the kmalhar/add-sec-tests branch December 5, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants