Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make lambda integ tests synchronous #91

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

philasmar
Copy link
Contributor

Issue #, if available:
DOTNET-7298

Description of changes:

  • Uncomment the Lambda integration tests that we commented out due to them failing in the release pipeline.
  • Changed the external processes from async to sync to account for the tests that take way longer to execute in the release pipeline as opposed to locally. Each test was taking around 15 mins in the release pipeline as opposed to seconds locally. I didn't want to cap it due to the weird behavior of the tests in the pipeline.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ashovlin
Copy link
Contributor

ashovlin commented Jan 3, 2024

Easier comparison from before we commented out the tests: 2bacb92...d1ed32d

Copy link
Contributor

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with this incremental approach to unblock the release pipeline.

I'm curious if you tried using pwsh like we do over in the Lambda repo?

I'm not aware of us encountering the issue over there (though those tests take pretty long so perhaps we never noticed).

@philasmar philasmar merged commit 227e47e into dev Jan 17, 2024
6 checks passed
@philasmar philasmar deleted the asmarp/fix-lambda-integ-tests branch March 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants