-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix optional fields in json #216
base: master
Are you sure you want to change the base?
Conversation
086ac3a
to
3004db8
Compare
3004db8
to
bd88fc1
Compare
@mohitpali any chance you can leave some feedback on this small change? It is preventing us from using schemas like the one defined in the test. Thank you |
also not sure why that schema is being parsed as |
Hello, do you mind create a issue to describe the problem we are trying to resolve here so we can have more context before we start the review process? |
made an issue here @YangSan0622 |
Please add unit tests or fix them to help us understand the issue better - tests are failing with error -
|
It looks like the test failure mentioned is still there. Do we know what is going on? |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.