-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the target scala version to 2.13 for mbknor-jackson-jsonschema and kafka #310
Conversation
Can you please run the integration tests as well? |
Does this actually publish something as a 2.13, and wouldn't you want to publish to both a 2.12 and a 2.13? |
Please add the motivation for this PR. |
Sure. Added the testing notes to the PR description. @blacktooth |
Updated the PR descriptions. |
No. The glue-schema-registry currently has dependency on libraries that are compiled with Scala 2.12. This PR attempts to replace those libraries with ones that are compiled with 2.13 instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration test failure was something existed for a while, those failure disappear if we run those tests by itself. I think it is safe to merge the change.
I'm still a bit concerned this will break bin-compat with my scala 2.12 app. Is there a test artifact? |
Yes, this can potentially break existing builds. @junyuc25 The preferable solution is to push a separate artifact for 2.13. |
Issue #, if available:
Description of changes:
Updating the following libraries to use the version compiled with Scala 2.13.
Motivation:
There is ongoing work to upgrade AWS SDK to V2 for the Apache Spark as tracked in this Jira. When upgrading the Spark Kinesis connector module (which transitively depends on glue-schema-registry), the GSR library also pulls in
mbknor-jackson-jsonschema_2.12
. However, as Apache Spark 4.0 release will drop support for scala 2.12 (Jira ticket), this lib is considered as banned dependency, resulting in build failures. We would need to replace dependencies that are compiled with scala 2.12 within the GSR repository to proceed with the SDK upgrade. Hence this PR.Example build failure information:
Testing:
mvn clean package
run-local-tests.sh
. Although there are 3 test failures, these failures are also observed when running against master branch. Hence they should not be caused by this PR.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.