Attempt to locate OpenSSL on MacOS if pkg-config detection fails #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,6 +133,26 @@ configure_file("source/Version.h.in" "${PROJECT_BINARY_DIR}/Version.h") | |||
| # OpenSSL dependency # | |||
| ######################################### | |||
| set(OPENSSL_USE_STATIC_LIBS TRUE) | |||
|
|
|||
| if(APPLE) | |||
There was a problem hiding this comment.
At this moment, Device Client does not provide support for MacOS. This is mainly because of the shadow feature of device client which does not work on MacOS because of dependency issue which is expected and known. Even if your change over here solves the issue of finding the OpenSSL on MacOS, we cannot push this change since it will give the wrong impression of device client is being supported on MacOS which is not true. For this reason we will have to close this review.
When we add support for Device Client on MacOS, we can reopen this review and merge your changes.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Change summary
One modification to the CMakeLists.txt file that will search for homebrew installations of OpenSSL (on MacOS only) and then find the latest version to build with.
Testing
No CI for this but I needed to make this change in order to build the project on Mac OS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.