Switch to fork from vfork #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids deprecation warnings and works on MacOS
|
During "cmake --build . --target aws-iot-device-client" I get this: |
| @@ -270,7 +270,7 @@ int JobEngine::exec_cmd(string operation, PlainJobDocument::JobAction action) | |||
|
|
|||
| int execResult; | |||
| int returnCode; | |||
| int pid = vfork(); | |||
| int pid = fork(); | |||
There was a problem hiding this comment.
Child process created byvfork() suspends execution of parent process until child process completes its execution wereas, both parent and the child process created usingfork() start their execution from next statement after fork() and both processes get executed simultaneously.
This might result in executing multiple job executions simultaneously.
Device Client anyways does not work on Mac OS so I would not encourage making this change until we make the software MacOS compatible.
There was a problem hiding this comment.
The child and parent process do different things. The parent process waits for the child process to finish already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Change summary
Just one change of vfork -> fork
Testing
No CI for this but I needed to make this change in order to build the project on Mac OS. fork does work slightly differently than vfork though so I may add some more comments later once I've verified that it works as expected.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.