Add more valgrind suppressions + fixes #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerZhongAWS
force-pushed
the
valgrindClean
branch
from
150c1c6
to
3e2c5a2
Compare
|
maybe using multiple suppression files would be better.. |
RogerZhongAWS
force-pushed
the
valgrindClean
branch
2 times, most recently
from
49c81e7
to
b01459c
Compare
RogerZhongAWS
force-pushed
the
valgrindClean
branch
4 times, most recently
from
33328c2
to
7fa15b6
Compare
RogerZhongAWS
force-pushed
the
valgrindClean
branch
from
c0ad1f7
to
600eb7b
Compare
RogerZhongAWS
force-pushed
the
valgrindClean
branch
from
600eb7b
to
53e7b1d
Compare
RogerZhongAWS
force-pushed
the
valgrindClean
branch
from
53e7b1d
to
e73645e
Compare
RogerZhongAWS
force-pushed
the
valgrindClean
branch
3 times, most recently
from
f274165
to
ed65e77
Compare
RogerZhongAWS
force-pushed
the
valgrindClean
branch
from
3de42e8
to
fb027a0
Compare
RogerZhongAWS
force-pushed
the
valgrindClean
branch
from
bbd3bd8
to
bec4b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Change summary
Fixed problems that are for certain related to device client
Added valgrind suppressions for everything else (direct and indirect leaks from elsewhere)
Testing
Tested by running valgrind on device client with no features, + jobs, + ST, + DD, + pubsub, + fp, + shadows, + sensor publish
Still not 100% clean, may need followup PR's to address everything.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.