Updated SDK commit to use the latest SDK code #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoemorais-aws
previously requested changes
Jun 12, 2023
HarshGandhi-AWS
commented
Jun 20, 2023
test/config/TestConfig.cpp
Outdated
| @@ -154,6 +156,8 @@ TEST_F(ConfigTestFixture, AllFeaturesEnabled) | |||
| "secure-element-token-label": "token-label" | |||
| } | |||
| })"; | |||
| SharedCrtResourceManager resourceManager; | |||
There was a problem hiding this comment.
Isn't one of these already initialized in ConfigTestFixture?
HarshGandhi-AWS
force-pushed
the
updateSDKVersion
branch
from
6610e14
to
4d4a60d
Compare
…or and api handle. This will resolve the Sensor pullish unit tests which manually creates and initializes allocator and eventloop.
This change will be reverted later. Added this to investigate DD integ test failure
…pendency version(#426) * updated code to shutdown on tunnel close callback * addressed lint errors * addressed lint errors * addressed lint errors * updated zlib version * updated zlib version * updated comment
…427) * Updated tunnel shutdown logic for Secure Tunneling component * removed extra log statement
There is an additional level of indirection required for the script to be able to build the container. Co-authored-by: Miguel Cano <macano953@users.noreply.github.com>
* Update Dockerfile * Update README.md
RogerZhongAWS
previously approved these changes
Dec 20, 2023
HarshGandhi-AWS
dismissed
RogerZhongAWS’s stale review
The merge-base changed after approval.
RogerZhongAWS
previously approved these changes
Dec 20, 2023
HarshGandhi-AWS
dismissed stale reviews from RogerZhongAWS and marcoemorais-aws
The merge-base changed after approval.
RogerZhongAWS
previously approved these changes
Dec 20, 2023
HarshGandhi-AWS
dismissed
RogerZhongAWS’s stale review
The merge-base changed after approval.
BolongZhang-AWS
previously approved these changes
Dec 20, 2023
HarshGandhi-AWS
dismissed
BolongZhang-AWS’s stale review
The merge-base changed after approval.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Change summary
initializeAllocatormethod to public so it can be called from outside ofSharedCrtResourceManager.SharedCrtResourceManager::disconnectmethod.inittwice when FP is enabled. https://github.com/awslabs/aws-iot-device-client/pull/391/filesRevision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
SharedCrtResourceManager::disconnectmethod.Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.