Cleanup IAM definitions #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two different definitions of IAM policies and statement. These changes centralize them both into one. These changes also add the `Condition` field that was missing from both implementations. These changes also make `Effect` to be an enum with the default `Allow`, instead of an optional string. This is more ergonomic than checking whether the effect is none or `allow`. Signed-off-by: David Calavera <david.calavera@gmail.com>
Keep all deserialization logic together, it's easier to manage. Signed-off-by: David Calavera <david.calavera@gmail.com>
|
@aesterline since it looks like you're using these events, you might want to take a pass at reviewing these changes |
I pulled this branch into our code and ran it through our tests. Everything works! Looks good to me. Thanks for the more thorough implementation. |
bnusunny
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We have two different definitions of IAM policies and statement. These changes centralize them both into one.
These changes also add the
Conditionfield that was missing from both implementations.These changes also make
Effectto be an enum with the defaultAllow, instead of an optional string. This is more ergonomic than checking whether the effect is none orallow.By submitting this pull request