[DynamoDB event] Makes ApproximateCreationDateTime optional in StreamRecord #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt stream record closes #889
jfkisafk
commented
Jun 6, 2024
| #[serde(rename = "ApproximateCreationDateTime")] | ||
| #[serde(with = "float_unix_epoch")] | ||
| #[serde(default)] | ||
| pub approximate_creation_date_time: DateTime<Utc>, |
There was a problem hiding this comment.
Did not want to change contracts by making this Option<DateTime<Utc>>, but if that makes more sense please let me know.
There was a problem hiding this comment.
this is a good approach, thanks!
calavera
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: closes #889
Description of changes: Makes the DDB event StreamRecord more robust, b/c it appears that
ApproximateCreationDateTimecan be absent. The DDB docs are ambiguous in this matter as they suggest it is not required but also say:Maybe we can get more guidance from DDB team?
By submitting this pull request
cargo testcargo fmt