Make root level tracing span (TracingLayer) optional #911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📬 A demo implementation for the log clutter issue discussed in #672.
It needs more work (docs, tests, better env var parsing)
✍️ Description of changes:
Reuse
AWS_LAMBDA_LOG_FORMAT
to specify if the root span should not be created.E.g.
AWS_LAMBDA_LOG_FORMAT=no-span
orAWS_LAMBDA_LOG_FORMAT=json,no-span
The
TracingLayer
is added by default and not added ifAWS_LAMBDA_LOG_FORMAT
containsno-span
.Impact
This last point allows using different log formats in different environments without code changes.
Examples
Including the root span
No root span (the main goal of this PR)
Root span + JSON
No root span + JSON
🔏 By submitting this pull request
cargo +nightly fmt
.cargo clippy --fix
.