Fix 308: Statements with same ConnectionProxy should be distinct #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hashCode and equals methods for ClientPreparedStatements created by the same ConnectionProxy. Distinct Statements that share the same ConnectionProxy should not have the same hash code value and should not be equal via the equals() method.
|
No unit tests added because mockito doesn't allow for mocking |
erolatreston
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hashCode and equals methods for ClientPreparedStatements created by the same ConnectionProxy. Distinct Statements that share the same ConnectionProxy should not have the same hash code value and should not be equal via the equals() method.
Summary
See #308
Fix hashCode and equals methods for ClientPreparedStatements created by the same ConnectionProxy. Distinct Statements that share the same ConnectionProxy should not have the same hash code value and should not be equal via the equals() method.
Description
Removed code to use the equals and hashcode implementations of the ConnectionProxy object and instead deferring to the underlying object's implementation.
Additional Reviewers