refactor: reduce map lookups to reduce number of locks required #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
isJDBCInterface_performance_optimization
branch
2 times, most recently
from
fefe872
to
e324efb
Compare
brunos-bq
reviewed
Mar 16, 2023
| "executeWithFlags", | ||
| "getParameterMetaData" | ||
| )); | ||
| private final static Set<String> METHODS_REQUIRE_UPDATED_TOPOLOGY = new ConcurrentHashMap<String, String>() {{ |
There was a problem hiding this comment.
will you use any Map functions on this Map? Or just searches on the keySet?
There was a problem hiding this comment.
ConcurrentHashMap.newKeySet()
sergiyvamz
approved these changes
Mar 17, 2023
karenc-bq
force-pushed
the
isJDBCInterface_performance_optimization
branch
from
cc73378
to
11d724f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of calling
containsKeythen callingget, which requires looking up the map twice, simply call get and check the value. This works because the map doesn't store null values.Description
Additional Reviewers
@brunos-bq
@aaronchung-bitquill