Remove the isMultiWriterCluster flag from the AuroraTopologyService #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
reviewed
May 5, 2023
| null : previousTopology.get(FailoverConnectionPlugin.WRITER_CONNECTION_INDEX); | ||
|
|
||
| // There is potentially a stale record. Do not add it to the hosts list. | ||
| if (writerCount == 2 |
There was a problem hiding this comment.
And if it's more than 2 writers found? Like few stale writer records. Is it possible to process all stale records and keep the latest one?
sergiyvamz
reviewed
May 6, 2023
| @@ -1055,7 +1055,8 @@ ConnectionProperties.useAwsIam=Set to true to use AWS IAM database authenticatio | |||
|
|
|||
| AuroraTopologyService.1=[AuroraTopologyService] clusterId=''{0}'' | |||
| AuroraTopologyService.2=[AuroraTopologyService] clusterInstance host=''{0}'', port={1,number,#}, database=''{2}'' | |||
| AuroraTopologyService.3=[AuroraTopologyService] The topology query returned an invalid topology - no writer instance detected | |||
| AuroraTopologyService.3=[AuroraTopologyService] The topology query returned an invalid topology - no writer instance detected. | |||
| AuroraTopologyService.4=[AuroraTopologyService] The topology query returned an invalid topology - multi-writer is not supported. | |||
There was a problem hiding this comment.
That looks like a message we no longer need. Everything related to multi-writers should go.
crystall-bitquill
force-pushed
the
remove-isMultiWriterCluster
branch
from
a5615c0
to
480805c
Compare
crystall-bitquill
force-pushed
the
remove-isMultiWriterCluster
branch
from
57ffae1
to
6270dd2
Compare
sergiyvamz
reviewed
May 8, 2023
| } else { | ||
| // Store the first writer to its expected position [0]. If there are other writers or stale records, ignore them. | ||
| // ResultSet and writers list is already ordered by latest updated after querying with RETRIEVE_TOPOLOGY_SQL. | ||
| hosts.add(FailoverConnectionPlugin.WRITER_CONNECTION_INDEX, writers.get(0)); |
There was a problem hiding this comment.
writers.get(0) may contain not the latest writer node. I think we still need to sort writers collection by last updated date.
sergiyvamz
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the isMultiWriterCluster flag from the AuroraTopologyService
Description
Multi writer clusters are not longer supported, so the isMultiWriterCluster flag that was used to disable failover has been removed. Additionally, checks have been added to ensure stale writer records that are obtained post writer-failover are not being used.
Additional Reviewers