fix: batch execute with comments results in error #470
Conversation
|
|
||
| /** | ||
| * Test fix for Issue #464. Executing a batch statement should ignore any comments. | ||
| * |
There was a problem hiding this comment.
NIT: I'd suggest adding an extra line like
"Verifying that isNonResultSetProducingQuery() properly handles queries that return queryReturnType == QueryReturnType.NONE
| bstmt.addBatch("-- Comment 6"); | ||
|
|
||
| try { | ||
| bstmt.executeBatch(); |
There was a problem hiding this comment.
is addBatch() that returns NONE or executeBatch() or both?
There was a problem hiding this comment.
The executeBatch() method triggers the query type check, addBatch() will not.
crystall-bitquill
force-pushed
the
issue-464
branch
from
6e29788 to
3df32ca
Compare
|
Yes, that did seem to fix the problems with .batchUpdate() not handling comments correctly. Thank you. I would suggest also opening a PR to the Oracle MySQL repo (https://github.com/mysql/mysql-connector-j) so that your fix will eventually get applied there. But, I guess if no additional work is going to be done on this driver for AWS, no point. Thank you, regardless! |
Summary
Batch execute with comments results in error
Description
Batch execute with comments resulted in errors about being unable to issue statements that produce result sets. The
isNonResultSetProducingQuerymethod was missing theNonequery return type.Addresses #464
Additional Reviewers