chore: MySQL China endpoints #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
reviewed
Jan 23, 2024
src/main/user-impl/java/com/mysql/cj/jdbc/ha/plugins/failover/FailoverConnectionPlugin.java
Show resolved
Hide resolved
brunos-bq
reviewed
Jan 23, 2024
src/main/user-impl/java/com/mysql/cj/jdbc/ha/plugins/failover/FailoverConnectionPlugin.java
Outdated
Show resolved
Hide resolved
src/main/user-impl/java/com/mysql/cj/jdbc/ha/plugins/failover/FailoverConnectionPlugin.java
Outdated
Show resolved
Hide resolved
src/main/user-impl/java/com/mysql/cj/jdbc/ha/util/RdsUtils.java
Outdated
Show resolved
Hide resolved
src/main/user-impl/java/com/mysql/cj/jdbc/ha/plugins/failover/FailoverConnectionPlugin.java
Show resolved
Hide resolved
src/main/user-impl/java/com/mysql/cj/jdbc/ha/plugins/failover/FailoverConnectionPlugin.java
Outdated
Show resolved
Hide resolved
sergiyvamz
approved these changes
Jan 24, 2024
|
Many thanks for the fix @crystall-bitquill! I tried the latest snapshot version 1.1.14-SNAPSHOT and confirmed the reported issue is now resolved. And we will switch to the Cheers, James |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MySQL - Update China endpoint patterns
Description
Refactored parsing logic to be centralized in RdsUtils. Updated functions and regex patterns to support Chinese endpoints. Added unit tests for testing endpoint regex.
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the GPLv2 license.