This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
JL UI - Conditional refresh display, team profiles fix, central component auto refresh, UI label cleanup #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding size attribute to the data dump.
…into feature/jl_storage_ui � Conflicts: � images/landing-page/package.json � images/landing-page/yarn.lock
…into main � Conflicts: � images/jupyter-user/extensions/jupyterlab_orbit/jupyterlab_orbit/handlers/storage.py � images/jupyter-user/extensions/jupyterlab_orbit/src/common/table.tsx � images/jupyter-user/extensions/jupyterlab_orbit/src/storage.tsx � images/jupyter-user/extensions/jupyterlab_orbit/test/mockup/catalog.json � images/jupyter-user/extensions/jupyterlab_orbit/test/mockup/containers-team.json � images/jupyter-user/extensions/jupyterlab_orbit/test/mockup/storage-clusterstorageclass.json � images/jupyter-user/extensions/jupyterlab_orbit/test/mockup/team.json � sdk/aws_orbit_sdk/controller.py
Adding containerCentral refresh icon.
Adding duration calculation for failed jobs.
…es in CodeArtifact.
* adding buildspec for the pipeline use * adding buildspec for the pipeline use * adding buildspec for the pipeline use * adding buildspec for the pipeline use * adding buildspec for the pipeline use * adding buildspec for the pipeline use * adding buildspec for the pipeline use * adding buildspec for the pipeline use * adding buildspec for the pipeline use * fix vpc for public * add destroy pipeline * deploy from code fix * deploy from code fix * fix req * fix req * fix req * fix req * don't create vpc ep when internet accessible * when using latest, must use locally build images * last fixes, if using latest then have to use dev-env for foundation because that is what the dev manifest uses * add regression step * had to add password for dockerhub cause building from source * remove passwords and fix path * need sdk to run regressions * fixing role for regression to be eks admin==foundation-admin
* fix vpc creation * fix vpc creation for public , not having isolated subnets * fix vpc creation for public , not having isolated subnets
…ich can deploy a least privileged IAM role to deploy the pre-requisistes of orbit deployment (#352) Co-authored-by: Srinivas Reddy Cheruku <seenureddy92@gmail.com>
* fix vpc creation * fix vpc creation for public , not having isolated subnets * fix vpc creation for public , not having isolated subnets * first round of fixes * fix public vpc * fix public vpc
…me is used for the build projects.
…into feature/delete_leftover_redshift_clusters
…into main � Conflicts: � cli/aws_orbit/data/toolkit/template.yaml
…and lake-uesr regression notebooks.
…eployed_profiles. Add env and eks cluster name to the teams UI.
…into feature/jl_ui_changes_1
Fixing teams refresh endpoint call.
…376) * rollback toolkit permissions; use utils for template on ssm manifest * black fix
…L UI backend call.
stthoom
changed the title
abaror
reviewed
Apr 11, 2021
sdk/aws_orbit_sdk/controller.py
Outdated
| @@ -464,6 +464,30 @@ def list_storage_class(): | |||
| return res["items"] | |||
|
|
|||
|
|
|||
| def get_nodegroups(cluster_name: str): | |||
| return_response = [] | |||
| eks_client = boto3.client("eks") | |||
There was a problem hiding this comment.
so what will happen on isolated subnets without EP?
There was a problem hiding this comment.
Will remove this method. Replacing with lamda to handle the eks service call.
abaror
previously approved these changes
Apr 11, 2021
…Instead will replace with lambda to handle the eks serivce calls from the SDK.
abaror
approved these changes
Apr 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
JL UI - Conditional refresh display, team profiles fix, central component auto refresh, UI label cleanup.
Managednode details in next PR.
Issue Reference URL
https://github.com/awslabs/aws-eks-data-maker/issues/
Do not change content below. Mark applicable check boxes only.
Thank you for submitting a contribution to AWS Orbit Workbench.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
For code changes: