Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add integration tests for SSO credential provider #1097

Closed
sichanyoo opened this issue Aug 28, 2023 · 2 comments
Closed

fix: Add integration tests for SSO credential provider #1097

sichanyoo opened this issue Aug 28, 2023 · 2 comments
Assignees
@sichanyoo
Labels
chore Internal work that does not affect the customer. feature-request A feature should be added or improved.
Milestone
GA

Comments

@sichanyoo
Copy link
Contributor

sichanyoo commented Aug 28, 2023 •
edited
Loading

Describe the issue

SSO credentials provider wrapper in Swift SDK is currently tested manually. Integration tests that automatically test it using AWS CLI should be added.

Links

SSO credentials provider source: https://github.com/awslabs/aws-sdk-swift/blob/main/Sources/Core/AWSClientRuntime/Auth/CredentialsProviders/SSOCredentialsProvider.swift
@sichanyoo sichanyoo added the chore Internal work that does not affect the customer. label Aug 28, 2023
@sichanyoo sichanyoo added this to the GA milestone Aug 28, 2023
@sichanyoo sichanyoo added the needs-triage This issue or PR still needs to be triaged. label Aug 29, 2023
@sichanyoo sichanyoo self-assigned this Aug 30, 2023
@sichanyoo sichanyoo added feature-request A feature should be added or improved. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 30, 2023
@sichanyoo
Copy link
Contributor Author

PR: #1129

@sichanyoo sichanyoo mentioned this issue Sep 20, 2023
Closed
@jbelkins
Copy link
Contributor

Released in AWS SDK for Swift 0.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sichanyoo sichanyoo

Labels
chore Internal work that does not affect the customer. feature-request A feature should be added or improved.
Projects
None yet
Milestone
GA
Development

No branches or pull requests
2 participants
@jbelkins @sichanyoo