fix: Add sso credentials integration test #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
changed the title
jbelkins
requested changes
Sep 20, 2023
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Show resolved
Hide resolved
| managedPolicyArn: awsReadOnlyPolicy, | ||
| permissionSetArn: permissionSetArn)) | ||
| } catch let error as AWSSSOAdmin.ConflictException { | ||
| if error.message == "PermissionSet with name \(permissionSetName) already exists." { |
There was a problem hiding this comment.
Assume error messages can change at any time. Is there a more reliable way to verify this error condition?
There was a problem hiding this comment.
Currently there's no other way to check the specific cause for the error other than checking the message contained int he error. So as a workaround I now look for smaller substring using contains() to reduce dependency on the entire error message string staying the same. Now it only checks that \(permissionSetName) already exists is part of the error message.
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
dayaffe
requested changes
Sep 20, 2023
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
dayaffe
reviewed
Sep 20, 2023
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
dayaffe
reviewed
Sep 20, 2023
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
dayaffe
reviewed
Sep 20, 2023
IntegrationTests/Services/AWSS3IntegrationTests/SSOCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
jbelkins
approved these changes
Sep 21, 2023
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
Adds integration test for
SSOCredentialsProviderthat usesS3::listBuckets.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.