Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"EC2EmptyQueryLists" protocol test fails #1514

Closed
jbelkins opened this issue May 21, 2024 · 0 comments
Closed

"EC2EmptyQueryLists" protocol test fails #1514

jbelkins opened this issue May 21, 2024 · 0 comments
Assignees
Labels
bug This issue is a bug.
Milestone

Comments

@jbelkins
Copy link
Contributor

Describe the bug

There is a new protocol test in Smithy 1.49.0 that does not pass because Swift SDK serialization of empty lists in EC2Query is incorrect.

The test: Ec2QueryTestSDKTests.QueryListsRequestTest testEc2EmptyQueryLists()

Test has been disabled in codegen until this issue can be corrected.

Expected Behavior

Test Ec2QueryTestSDKTests.QueryListsRequestTest testEc2EmptyQueryLists() passes

Current Behavior

Test Ec2QueryTestSDKTests.QueryListsRequestTest testEc2EmptyQueryLists() fails as follows:

Test Case '-[Ec2QueryTestSDKTests.QueryListsRequestTest testEc2EmptyQueryLists]' started.
/Users/jbelkins/Code/Xcode3/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/ec2-query/swift-codegen/Ec2QueryTestSDKTests/QueryListsRequestTest.swift:122: error: -[Ec2QueryTestSDKTests.QueryListsRequestTest testEc2EmptyQueryLists] : XCTAssertTrue failed - 
Actual: ListArg=&Action=QueryLists&Version=2020-01-08
Expected: Action=QueryLists&Version=2020-01-08

Reproduction Steps

  • Set Smithy version to 1.49.0
  • Enable this test by removing "EC2EmptyQueryLists" from the testsToIgnore in the EC2 protocol generator, if needed
  • Generate & run protocol tests
  • Observe results

Possible Solution

No response

Additional Information/Context

No response

AWS SWIFT SDK version used

main

Compiler and Version used

Xcode 15.4

Operating System and version

macOS 14.4.1

@jbelkins jbelkins added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. area/protocol-tests labels May 21, 2024
@jbelkins jbelkins changed the title (short issue description) "EC2EmptyQueryLists" protocol test fails May 21, 2024
@jbelkins jbelkins added this to the GA milestone Jun 3, 2024
@jbelkins jbelkins removed the needs-triage This issue or PR still needs to be triaged. label Jun 3, 2024
@sichanyoo sichanyoo assigned dayaffe and sichanyoo and unassigned dayaffe Jul 29, 2024
@sichanyoo sichanyoo reopened this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants