chore: Update to Smithy 1.49.0 #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
May 21, 2024
| @@ -28,7 +28,7 @@ class AWSDeprecatedShapeRemover : SwiftIntegration { | |||
| Predicate<Shape> { | |||
| val since = it.getTrait<DeprecatedTrait>()?.since?.orElse(null) ?: return@Predicate false | |||
| val deprecatedDate = since.toLocalDate() ?: return@Predicate false.also { | |||
| println("Failed to parse `since` field $since as a date, skipping removal of deprecated shape $it") | |||
| println("Could not parse `since` field \"$since\" as a date, skipping removal of deprecated shape $it") | |||
There was a problem hiding this comment.
Changed this language because use of the word "failed" makes it difficult to search logs for test failures.
jbelkins
commented
May 21, 2024
| @@ -27,6 +27,7 @@ class EC2QueryProtocolGenerator : AWSHTTPBindingProtocolGenerator(EC2QueryCustom | |||
| override val testsToIgnore = setOf( | |||
| "SDKAppliedContentEncoding_ec2Query", | |||
| "SDKAppendsGzipAndIgnoresHttpProvidedEncoding_ec2Query", | |||
| "Ec2EmptyQueryLists", | |||
There was a problem hiding this comment.
Will fix this test in a separate ticket.
#1514
jbelkins
commented
May 21, 2024
| @@ -25,7 +25,7 @@ class OperationEndpointResolverMiddlewareTests { | |||
| guard let region = config.region else { | |||
| throw SdkError<GetThingOutputError>.client(ClientError.unknownError(("Missing required parameter: region"))) | |||
| } | |||
| let endpointParams = EndpointParams(boolBar: true, boolBaz: input.fuzz, boolFoo: config.boolFoo, endpoint: config.endpoint, region: region, stringBar: "some value", stringBaz: input.buzz, stringFoo: config.stringFoo) | |||
| let endpointParams = EndpointParams(boolBar: true, boolBaz: input.fuzz, boolFoo: config.boolFoo, endpoint: config.endpoint, region: region, stringArrayBar: ["five", "six", "seven"], stringBar: "some value", stringBaz: input.buzz, stringFoo: config.stringFoo) | |||
There was a problem hiding this comment.
Added a test that code-generates a static param typed to stringArray.
jbelkins
commented
May 21, 2024
| staticContextParam.value.toString() | ||
| } | ||
| } | ||
| swiftParam(param.type, staticContextParam.value) |
There was a problem hiding this comment.
Refactored this logic to a private method just below.
jbelkins
commented
May 21, 2024
| @@ -61,6 +61,6 @@ fun ParameterType.toShapeType(): ShapeType? { | |||
| return when (this) { | |||
| ParameterType.STRING -> ShapeType.STRING | |||
| ParameterType.BOOLEAN -> ShapeType.BOOLEAN | |||
| else -> null | |||
| ParameterType.STRING_ARRAY -> ShapeType.LIST | |||
There was a problem hiding this comment.
Added STRING_ARRAY case and eliminated the else so this fails to compile when the next new ParameterType case is added.
2 tasks
dayaffe
approved these changes
May 22, 2024
sichanyoo
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1513
Description of changes
Updates Smithy from 1.47.0 to 1.49.0.
Corresponding smithy-swift PR: smithy-lang/smithy-swift#733
Specific changes:
stringArraytype for endpoint params.StaticContextParamendpoint param binding that is typedstringArray.Two items related to this upgrade have been split into separate issues:
EC2EmptyQueryListsprotocol test)OperationalContextParamsendpoint param binding)New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.